Pick rc2 fixes for msbuild telemetry and sdkresolver to GA #51090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagilson
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
LGTM - I'm not sure why release/10.0.1xx...release/10.0.1xx-rc2#diff-58f51f11a7ac3d6d7da0423eeaeef2d82bfd47b27d7663ec9a842acb07b16487 is wrong about some of the missing code changes, even the first line (changing {RuntimeIdentifier} to (RuntimeIdentifier) when that exact sha isn't in the history but the code change is there in 10.0... GitHub diffs are just wrong sometimes.
Anyways, I verified some of the other missing changes and this seems good. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a the result of merging release/10.0.1xx-rc2 and release/10.0.1xx, and keeping just the code changes. Dependency flows are more complex and I don't have the domain knowledge to deal with them.